Removed GLSLInputAttachmentIndexLayoutModifier and the somewhat 'hacky' binding model 'input_attachment' previously relied upon. This was changed to work with the slang-type-layout rules system. This means we propagate resourceInfo rather than a modifier to store 'input_attachment' binding data. This change allows Slang automatic bindings, HLSL bindings, GLSL bindings, and translation of GLSL to and from HLSL bindings to work as expected.
Added default argument float4 to SubpassInput.
Merged glsl.meta and hlsl.meta SubpassInput logic.
Note:
To match how other bindings are validated (and used), validation for "input_attachment_index is only allowed to be used with SubpassInput" was removed. To validate requires full type value data. This is not ready by the point of checkModifiers/Attributes. If validation is desired, a separate check would need to be added for when adding parameter-bindings
fixes: #4440
GLSLInputAttachmentIndexLayoutModifier
and the somewhat 'hacky' binding model 'input_attachment' previously relied upon. This was changed to work with the slang-type-layout rules system. This means we propagate resourceInfo rather than a modifier to store 'input_attachment' binding data. This change allows Slang automatic bindings, HLSL bindings, GLSL bindings, and translation of GLSL to and from HLSL bindings to work as expected.float4
to SubpassInputNote:
input_attachment_index
is only allowed to be used withSubpassInput
" was removed. To validate requires full type value data. This is not ready by the point of checkModifiers/Attributes. If validation is desired, a separate check would need to be added for when adding parameter-bindings