search

shader-slang / slang

Making it easier to work with shaders
http://shader-slang.com
Other
3.18k stars 214 forks source link

PR gets stuck when there are only document changes #5689

Open jkwak-work opened 6 days ago

jkwak-work commented 6 days ago

When PR has only document files changed, the CI gets stuck. "build"-s are not supposed to be triggered but they are. I am not sure if it related to the recent change with "licence/cla" action.

image

jkwak-work commented 6 days ago

Two examples can be found here:

expipiplus1 commented 4 days ago

It is because that CI ignores changes restricted to the docs directory, this is safe to ignore. Or we can unconditionally run such workflows

jkwak-work commented 4 days ago

Why does the build workflows are triggered in the first place? The label checking workflow seems to be doing fine as expected in a way that it is not triggered at all. They seem to have the same path-ignore settings.

csyonghe commented 7 hours ago

The tests are showing up because the repo is configured to expect these tests to pass, when in fact they are not triggered. This is just a github display issue, and no tests are actually stuck.

csyonghe commented 7 hours ago

See https://github.com/shader-slang/slang/settings/branch_protection_rules/1102224 under "Require status checks to pass before merging"