search

shadoof / rtwtr

reading through writing through ...
GNU General Public License v3.0
0 stars 1 forks source link

when there is no actual text to replace anything in the `a_file` #22

Closed shadoof closed 4 years ago

shadoof commented 4 years ago

in section 2 and 11 empty units are set up to in the b_file to correspond with extra text units in the a_file. The animation currently goes to onHover_opcity and then nothing happens. If there are no b_file spans at all then we need to have it theses text fade to fade_opacity after PHASE1_PHASE2_DELAY.

cqx931 commented 4 years ago

The current issue is that these units won't enter phase2 at all because there is no shared units to trigger the mouseover event. Do we have any other cases in the text where there is no shared units between one a b text pair? Anyway, even if we don't have that in the current text, this should be considered for a more general situation.

shadoof commented 4 years ago

I think section 2 and 11 are the only places in the current text. But yes, needs to be part of the general plan. I imagine that this could be handled by testing to see if there are any non-empty strings in the corresponding b_unit and if (b_unit is empty) then: so long as mouse is still within the a_unit, then behave exactly as if the pointer is over a shared span, i.e. fade the a_unit out to fade_opacity after the PHASE1_PHASE2_DELAY.

cqx931 commented 4 years ago

fixed https://github.com/shadoof/rtwtr/pull/33/commits/127961af760329eeb1665de46582c93e4ef706ab

In general, if there are no shared spans in b span. The app will still try to reposition everything in the b unit at a space, without considering anchor.