shadorki / genshin-impact-wish-simulator

A React web application to simulate Genshin Impact gacha in the browser
713 stars 162 forks source link

Reset banner bug fix #18

Closed lauslim12 closed 4 years ago

lauslim12 commented 4 years ago

Hello!

This PR fixes the bug as explained in issue #17, the changes are simple:

I have tested it in my web server (this includes last PR (#16) changes), and it works like a charm! No more switching to the beginner's wish if we rolled after clicking the reset button!

Don't forget to re-run npm run build after merging my previous and this PR, because I made this PR based on your master branch, not my cache-busting-improvements branch 😅.

I think that's all. Hope it helps and thank you!

Resolves #17

shadorki commented 4 years ago

Hey dude! Sorry I haven't had time to merge your last pr, I have to go out of town today so I'll take a look when I have a stable internet connection.

lauslim12 commented 4 years ago

Sure thing man! Take your time and don't worry about it haha!