search

shadow-maint / shadow

Upstream shadow tree
Other
287 stars 227 forks source link

Remove id(1) and groups(1) #1008

Closed alejandro-colomar closed 1 week ago

alejandro-colomar commented 1 month ago

Distributions use id(1) from GNU coreutils or BusyBox. Drop ours.

Closes: https://github.com/shadow-maint/shadow/issues/1005 Suggested-by: @dkwo Cc: @hallyn Cc: @ikerexxe Cc: @jubalh Cc: @thesamesam

Revisions:

v1b - Rebase ``` $ git range-diff master..gh/idgroups shadow/master..idgroups 1: 8e856bbd = 1: ba31ca7b Remove id(1) ```
v1c - Rebase ``` $ git range-diff alx/master..gh/idgroups shadow/master..idgroups 1: ba31ca7b = 1: b2cec0be Remove id(1) ```
v2 - Remove groups(1) ``` $ git range-diff shadow/master gh/idgroups idgroups 1: b2cec0be = 1: b2cec0be Remove id(1) -: -------- > 2: 451debfe Remove groups(1) ```
v2b - Rebase ``` $ git range-diff master..gh/idgroups shadow/master..idgroups 1: b2cec0be ! 1: 61d117c4 Remove id(1) @@ src/id.c (deleted) -#include -#include - --#include "alloc.h" +-#include "alloc/malloc.h" -#include "defines.h" - -/* local function prototypes */ 2: 451debfe ! 2: a539c303 Remove groups(1) @@ src/groups.c (deleted) -#include -#include - --#include "alloc.h" +-#include "alloc/x/xmalloc.h" -#include "defines.h" -#include "prototypes.h" -#include "shadowlog.h" ```
alejandro-colomar commented 1 month ago

I'll remove groups(1) in a separate PR, to have it piecemeal.

ikerexxe commented 1 month ago

I think we should do an announcement in a release notes indicating that we are deprecating it. Once that is done and nobody has complained we can proceed to remove it.

alejandro-colomar commented 1 month ago

I think we should do an announcement in a release notes indicating that we are deprecating it. Once that is done and nobody has complained we can proceed to remove it.

Okay. I'll then prepare the patch for groups(1) already, and will make this a draft, ready for when the announcement is done.