search

shadow-maint / shadow

Upstream shadow tree
Other
292 stars 228 forks source link

lib/chkname.c: An object cannot expand further than the universe in which it resides #1053

Closed alejandro-colomar closed 1 month ago

alejandro-colomar commented 1 month ago

If you want a larger object, you'll have to wait at least until the universe expands so much. (Or maybe not, but luckily, programming is simpler than physics.)

If an implementation doesn't recognize its own limitations, its a bug, not a feature.

Closes: https://github.com/shadow-maint/shadow/issues/1052 Cc: @stoeckmann

alejandro-colomar commented 1 month ago

I don't see us ever reaching that limit for username size, but it never hurts to be cautious. LGTM!

Agree. :)

It was more of a subliminal message to implementations that claim to not have any limits. (I think GNU Hurd is one.)

Thanks!