search

shadow-maint / shadow

Upstream shadow tree
Other
306 stars 237 forks source link

CI is broken #1088

Closed alejandro-colomar closed 4 weeks ago

alejandro-colomar commented 1 month ago

Hi @ikerexxe ,

I've seen some CI fail with the following error. Maybe you know why it happens?

Reading package lists...
E: You must put some 'deb-src' URIs in your sources.list
Error: Process completed with exit code 100.

https://github.com/shadow-maint/shadow/actions/runs/11315585583/job/31466940612?pr=1048

alejandro-colomar commented 1 month ago

Maybe https://linuxconfig.org/ubuntus-repository-configuration-ubuntu-sources-have-moved-to-etc-apt-sources-list-d-ubuntu-sources?

ikerexxe commented 1 month ago

Yes, that's probably the problem. If I remember correctly Debian also made a similar change. I'll take a look today ;)

alejandro-colomar commented 1 month ago

@ikerexxe

It seems to be bad again. This time it seems the .sources file doesn't exist. :/

cat: /etc/apt/sources.list.d/ubuntu.sources: No such file or directory

https://github.com/shadow-maint/shadow/actions/runs/11371739677/job/31634488628?pr=1095

Can you have a look? In some cases, it seems to be running on Ubuntu 22, and in some other cases on Ubuntu 24.

ikerexxe commented 1 month ago

This seems to be a bug in the Github infrastructure since from shadow we always run the workflows in ubuntu-latest. I think it would be a good idea to open an issue at https://github.com/actions/runner-images/issues for Github to fix this problem.

alejandro-colomar commented 1 month ago

This seems to be a bug in the Github infrastructure since from shadow we always run the workflows in ubuntu-latest. I think it would be a good idea to open an issue at https://github.com/actions/runner-images/issues for Github to fix this problem.

Thanks! It seems it's alreayd open: https://github.com/actions/runner-images/issues/10636. Github seems to have rolled back the upgrade to 24. We'll have CI partially broken until they fix that. At least the alpine/fedora/debian builds are working. Those are the most important ones, IMO.

ikerexxe commented 1 month ago

I don't know who has made these decisions but I think they have been wrong several times :disappointed:

hallyn commented 4 weeks ago

@ikerexxe do you have a fix in the works for this, or should I take it?

I think our tests just have to check for which style sources.list we have, and do the right thing.