search

shadow-maint / shadow

Upstream shadow tree
Other
292 stars 228 forks source link

src/su.c: do_check_perms(): Fix -Wincompatible-pointer-types bug #916

Closed alejandro-colomar closed 7 months ago

alejandro-colomar commented 7 months ago

Fixes: ef95bb7ed139 ("src/su.c: Fix type of variable") Closes: https://github.com/shadow-maint/shadow/issues/915 Reported-by: @thesamesam Signed-off-by: @alejandro-colomar

thesamesam commented 7 months ago

Consider fixing CI too to add the other warnings-to-become-errors (https://wiki.gentoo.org/wiki/Modern_C_porting#What_changed.3F), as it would've found this?

alejandro-colomar commented 7 months ago

Consider fixing CI too to add the other warnings-to-become-errors (https://wiki.gentoo.org/wiki/Modern_C_porting#What_changed.3F), as it would've found this?

Yes, I want to do that. However, considering how much I've DoSed @hallyn and @ikerexxe with the current queue of hardening patches, I'd like to give them a break (at least merge all the patches I've already sent) before that. And maybe GCC 14 releases before that, and I don't need to do it. :)

thesamesam commented 7 months ago

Well, then you end up with someone having to file a bug like this, possibly after it made it into a release. But I understand, sure.

ikerexxe commented 7 months ago

LGTM!

ikerexxe commented 7 months ago

I don't have permissions to rebase and merge. Please feel free to do it on your own.

alejandro-colomar commented 7 months ago

I see this:

Merging is blocked
Merging can be performed automatically with 1 approving review.

I guess you need to click on approve.

ikerexxe commented 7 months ago

I guess you need to click on approve.

:facepalm: My bad