search

shadow-maint / shadow

Upstream shadow tree
Other
292 stars 228 forks source link

src/passwd.c: Remove comment about a -s flag #930

Closed alejandro-colomar closed 7 months ago

alejandro-colomar commented 7 months ago

That flag has never existed, AFAICS.

Closes: https://github.com/shadow-maint/shadow/issues/929 Cc: @thalman

alejandro-colomar commented 7 months ago

v2 changes:

$ git range-diff shadow/master gh/passwd_s passwd_s 
1:  2f83040e ! 1:  68f1c876 src/passwd.c: Remove comment about a -s flag
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>

      ## Commit message ##
    -    src/passwd.c: Remove comment about a -s flag
    +    src/passwd.c: Remove comment about flags that don't exist

    -    That flag has never existed, AFAICS.
    +    Those flag have never existed, AFAICS.

         Closes: <https://github.com/shadow-maint/shadow/issues/929>
         Cc: Tomas Halman <tomas@halman.net>
    @@ Commit message

      ## src/passwd.c ##
     @@ src/passwd.c: static void update_shadow (void)
    +  *
    +  *        -d      delete the password for the named account (*)
    +  *        -e      expire the password for the named account (*)
    +- *        -f      execute chfn command to interpret flags
    +- *        -g      execute gpasswd command to interpret flags
    +  *        -i #    set sp_inact to # days (*)
    +  *        -k      change password only if expired
       *        -l      lock the password of the named account (*)
       *        -n #    set sp_min to # days (*)
       *        -r #    change password in # repository
alejandro-colomar commented 7 months ago

v2b changes:

$ git range-diff shadow/master gh/passwd_s passwd_s 
1:  68f1c876 ! 1:  eb3b4d01 src/passwd.c: Remove comment about flags that don't exist
    @@ Metadata
     Author: Alejandro Colomar <alx@kernel.org>

      ## Commit message ##
    -    src/passwd.c: Remove comment about flags that don't exist
    +    src/passwd.c: Remove comments about flags that don't exist

    -    Those flag have never existed, AFAICS.
    +    Those flags have never existed, AFAICS.

         Closes: <https://github.com/shadow-maint/shadow/issues/929>
         Cc: Tomas Halman <tomas@halman.net>
alejandro-colomar commented 7 months ago

v2c changes:

$ git range-diff shadow/master gh/passwd_s passwd_s 
1:  eb3b4d01 ! 1:  91df1626 src/passwd.c: Remove comments about flags that don't exist
    @@ Commit message

         Closes: <https://github.com/shadow-maint/shadow/issues/929>
         Cc: Tomas Halman <tomas@halman.net>
    +    Cc: "Serge E. Hallyn" <serge@hallyn.com>
         Signed-off-by: Alejandro Colomar <alx@kernel.org>

      ## src/passwd.c ##