search

shadow-maint / shadow

Upstream shadow tree
Other
290 stars 228 forks source link

Update username length #986

Closed ikerexxe closed 2 months ago

jubalh commented 3 months ago

Looks good. I wonder whether it would make sense to mention https://github.com/shadow-maint/shadow/issues/584#issuecomment-2095340159 this as well.

alejandro-colomar commented 3 months ago

Could you add a

Fixes: 6a1f45d932c8 ("lib/chkname.c: Support unlimited user name lengths")

tag to the commit?

That way, it's easy to check when the change was actually done.

(I'm assuming this is documenting that commit 6a1f45d932c859725bc175f96f7c42b9ccc20ea4).

ikerexxe commented 2 months ago

I added the two references to make it clearer.

alejandro-colomar commented 2 months ago

Thanks!