The if ! wget -q --spider https://www.google.com/; then ... check could hang under certain bad connection conditions. We already had a timeout for the git pull, so remove the general internet connectivity check and print messages to tell the user whether git pull timed out or not
Checklist
Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.
Tests
[ ] No tests required to be added. (For small changes that will be tested by CI/CD infrastructure).
[ ] Added/Modified automated and PhantomHand CI tests (if a new class is added (Python or C++), the interface of that class must be unit tested).
[ ] Manually tested in simulation (if simulation specific or no hardware required to test the functionality).
[ ] Manually tested on hardware (if hardware specific or related).
Documentation
[ ] No documentation required to be added.
[ ] Added documentation (For any new feature, explain what it does and how to use it. Write the documentation in a relevant space, e.g. Github, Confluence, etc).
[ ] Updated documentation (For changes to pre-existing features mentioned in the documentation).
Proposed changes
The
if ! wget -q --spider https://www.google.com/; then ...check could hang under certain bad connection conditions. We already had a timeout for the git pull, so remove the general internet connectivity check and print messages to tell the user whether git pull timed out or notChecklist
Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.
Tests
Documentation