search

shadow-robot / optoforce

ROS driver for the Optoforce sensor
GNU General Public License v2.0
21 stars 17 forks source link

Multi sensor loading scaling file #16

Closed armando-montalvo closed 8 years ago

armando-montalvo commented 8 years ago

I modified the file taking into account the suggestions of @toliver and @dogoepp.

dogoepp commented 8 years ago

Any News on this pull request ?

armando-montalvo commented 8 years ago

Well, I've just made the changes and checked twice if there was something wrong, but I think it's good. Thanks a lot @toliver and @dogoepp for the feedback!

dogoepp commented 8 years ago

Thanks a lot @armando-montalvo ! I hope it can be merged soon.

armando-montalvo commented 8 years ago

@toliver, I was checking how to contact you directly, but as there is no e-mail listed in your profile, I have to ask you here. I am an intern in Fraunhofer IPA and was assigned to help maintain this code. We would like to add a wiki page for this package in the ROS wiki and modify the code to meet ROS Industrial standards, if that is ok for you guys. You can contact me directly in my e-mail (It's in my profile). Thanks!

toliver commented 8 years ago

@armando-montalvo I've just replied via email.

toliver commented 8 years ago

@armando-montalvo there seems to be some conflicts. Can you solve them so that we can merge?

toliver commented 8 years ago

And indeed thanks for your collaboration!!!