search

shadow-robot / sr-ros-interface

A ROS interface for Shadow Robot's hand.
GNU General Public License v2.0
22 stars 12 forks source link

fixing indentation automatically for all launch files using tidy #291

Closed ugocupcic closed 9 years ago

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 8104b48 on shadow-robot:B_fix_launch_indent into addae16 on shadow-robot:indigo-devel.

toliver commented 9 years ago

I have some doubts that this obsession with extra short lines actually makes things more readable. Same in python with the pep8. Happy to merge anyway.

ugocupcic commented 9 years ago

@toliver I agree about short lines - I was more aiming to fix really bad indentation (we have huge variations in some launch files with an amazing number of spaces and it's quite hard to read). I can take a look at tidy, see if there's some option to use a longer line break?

toliver commented 9 years ago

That would be good if there's an option. Unless other people prefer the shorter lines for a good reason.

ugocupcic commented 9 years ago

@toliver done (I used -w 200 to specify a go to line at column 200)

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 932c55c on shadow-robot:B_fix_launch_indent into addae16 on shadow-robot:indigo-devel.