search

shadow-robot / sr-ros-interface

A ROS interface for Shadow Robot's hand.
GNU General Public License v2.0
22 stars 12 forks source link

uncommented planners that are working #304

Closed beatrizleon closed 9 years ago

beatrizleon commented 9 years ago

Only TRRTkConfigDefault is giving errors so it is still commented

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 93beb6f on shadow-robot:F#270_moveit_planner into afed876 on shadow-robot:indigo-devel.

ugocupcic commented 9 years ago

Not directly related to this but I'm getting the following error when loading moveit:

[ERROR] [1433504838.775942782]: Link 'rh_mfmiddle' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776000388]: Link 'rh_ffmiddle' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776027476]: Link 'rh_ffmiddle' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776063101]: Link 'rh_ffdistal' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776098811]: Link 'rh_rfmiddle' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776129159]: Link 'rh_mfmiddle' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776157383]: Link 'rh_mfmiddle' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776190388]: Link 'rh_mfdistal' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776223425]: Link 'rh_lfmiddle' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776253053]: Link 'rh_rfmiddle' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776282747]: Link 'rh_rfmiddle' is not known to URDF. Cannot disable collisons.
[ERROR] [1433504838.776315468]: Link 'rh_rfdistal' is not known to URDF. Cannot disable collisons.
toliver commented 9 years ago

This is my fault. I added these "disable collision" to left hand SRDF as they were necessary, and then had the brilliant idea of copying them to the right hand, But the right hand is currently biotac, so those links don't exist. I will create an issue about that.

ugocupcic commented 9 years ago

Should we set limited to true by default?

ugocupcic commented 9 years ago

@beatrizleon don't hesitate to use images and gifs in your pr, it illustrates nicely :)

screencast

beatrizleon commented 9 years ago

I think we should set it to true by default at least until we manage to find out a way to remove the limitation. Should I change it?

ugocupcic commented 9 years ago

nod

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 5c005e1 on shadow-robot:F#270_moveit_planner into afed876 on shadow-robot:indigo-devel.

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 4d02ff4 on shadow-robot:F#270_moveit_planner into afed876 on shadow-robot:indigo-devel.