search

shadow-robot / sr-ros-interface

A ROS interface for Shadow Robot's hand.
GNU General Public License v2.0
21 stars 12 forks source link

F#344 cpp library to detect hand #355

Closed VahidAminZ closed 9 years ago

VahidAminZ commented 9 years ago

344

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 6cea1a1 on shadow-robot:F#344_cpp_library_to_detect_hand into 86fbe1b on shadow-robot:indigo-devel.

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 7fde89a on shadow-robot:F#344_cpp_library_to_detect_hand into bd61541 on shadow-robot:indigo-devel.

VahidAminZ commented 9 years ago

@toliver : fixed the indentation

toliver commented 9 years ago

Could you try what happens if no hand is present? (no "hand/mapping" or joint prefix parameters present)

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 1967cc7 on shadow-robot:F#344_cpp_library_to_detect_hand into bd61541 on shadow-robot:indigo-devel.

VahidAminZ commented 9 years ago

@toliver It reads the parameters from the description file but it will crash if no joint prefix is present.

toliver commented 9 years ago

That would need to be fixed. The idea behind the library is that a node will use it to discover what hands are present. So if no hands are present it doesn't have to crash. It should return empty maps or something similar.

VahidAminZ commented 9 years ago

@toliver : I think I got confused between this one and other PR for fixing the tests. It should be fine to run it without any hand. I will write a test for it.

VahidAminZ commented 9 years ago

@toliver added the extra test

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling e1c8f40 on shadow-robot:F#344_cpp_library_to_detect_hand into bd61541 on shadow-robot:indigo-devel.