search

shadow-robot / sr-ros-interface

A ROS interface for Shadow Robot's hand.
GNU General Public License v2.0
21 stars 12 forks source link

Bug in HandCommander.set_max_force #382

Closed toliver closed 8 years ago

toliver commented 9 years ago

The expected and documented behaviour

hand_cmd.set_max_force('rh_FFJ3', 200)

does not work. Right now what works is:

hand_cmd.set_max_force('FFJ3', 200)

So we should either modify the documentation and add a comment in the function signature...

Or modify the function so that strips the prefix from the joint_name argument. This is probably the cleanest solution, as it keeps the consistency with the rest of Commander methods.

ugocupcic commented 9 years ago

Yes, let's strip the prefix.

ugocupcic commented 8 years ago

Moving the issue to https://github.com/shadow-robot/sr_interface/issues/7