shadow-robot / sr_interface

Shadow Robot Interface packages
BSD 3-Clause "New" or "Revised" License
29 stars 18 forks source link

Fixed how sr_bimanual.launch deals with product types #799

Closed BenStarmerSmith closed 1 year ago

BenStarmerSmith commented 1 year ago

Proposed changes

Made sr_bimanual.launch look like srhand.launch by making one variable to change hand_type and it automatically updates the hand_version.

Checklist

Before posting a PR ensure that from each of the below categories AT LEAST ONE BOX HAS BEEN CHECKED. If more than one category is applicable then more can be checked. Also ensure that the proposed changes have been filled out with relevant information for reviewers.

Tests

Documentation

BenStarmerSmith commented 1 year ago

Screenshot from 2023-01-06 16-27-48 Screenshot of it working with Aurora oneliner (docker_deploy with hand_lite product)

BenStarmerSmith commented 1 year ago

Changed to match this file: https://github.com/shadow-robot/sr_interface/blob/dd12cb6b681c1ceb303a794bbbf00b8a27f80cd5/sr_robot_launch/launch/srhand.launch#L42-L46