search

shadow / shadow-plugin-tor

A Shadow plug-in that runs the Tor anonymity software
https://shadow.github.io
Other
49 stars 39 forks source link

Fix TorFlow candidate selection #83

Closed robgjansen closed 4 years ago

robgjansen commented 4 years ago

Correctly compute the minimum number of probes for each relay, and then actually select among the relays with that minimum number (rather than selecting candidates among all relays).

Fixes #82

robgjansen commented 4 years ago

@ccheng32 Thank you for pointing out the other error! Here is the new update. Please give this a try and let me know if you find more errors.

ccheng32 commented 4 years ago

Thanks! This fixes the issue. LGTM

robgjansen commented 4 years ago

Do we have any tests that cover this code?

I never wrote tests for the TorFlow module, unfortunately. FWIW, at this point this module is not actually used by default in our Tor simulations.