search

shadow / tornettools

A tool to generate realistic private Tor network models, run them in Shadow, and analyze the results.
Other
34 stars 15 forks source link

Update generated `environment` option for shadow 3.0 #98

Closed stevenengler closed 1 year ago

stevenengler commented 1 year ago

See shadow/shadow#2875.

stevenengler commented 1 year ago

I think this is the first change that breaks compatibility with shadow 2.x? @robgjansen do you want to tag a release first?

If you do tag a new release, maybe do the tag at 21706fce1. The last few PRs/commits in main were intended for 3.0 compatibility, and I don't think they break 2.x compatibility, but i also only did little testing for 2.x. So since they don't add anything for 2.x simulations, I think it would be safer to tag the release before those PRs.

Edit: If tornettools has versions strings somewhere, we shouldn't use the tag above, and instead should update the version string and tag a new commit.

robgjansen commented 1 year ago

New release here: https://github.com/shadow/tornettools/releases/tag/v2.0.0

Bumping version requires a commit+tag, so I did not tag the older commit hash.