Upgrade in progress popup appears when checking for an upgrade

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Navigate to Upgrade Policy.
2. Change it to Let me check for upgrades.
3. While it is checking, close Stoffi.

What should have happened?
Stoffi is only checking to see if there is an upgrade or not. It hasn't started 
an actual upgrade. The dialog is incorrect. When I saw that dialog this 
morning, I thought you had released Beta Four :)

If it is checking for an update and Stoffi is closed, let Stoffi close without 
a dialog appearing.

What happened instead?
There is an upgrade in progress dialog appears. Are you sure you want to quit?

Can you give us any additional information that could be useful in fixing
this bug?

What release of Stoffi are you using (Xia or Shang)?
Zhou

If you are using alpha or beta, please state which:
Beta Three

Original issue reported on code.google.com by wic...@gmail.com on 22 Apr 2012 at 11:55

[GoogleCodeExporter]

This is because of the nature of the upgrade process:

Client to Server: Hey, I'm at this version.

Scenario 1:
Server to Client: You don't need an upgrade (text response)

Scenario 2:
Server to Client: Here's all upgrades for you (big file)

Scenario 3:
Server to Client: Error (text response)

I kept it extremely simple to make it use less resources and bandwidth since 
we're using HTTPS.

My proposed solution: when the client sends the first request, create a timer 
which will trigger the "now you can't close without a popup" after, say 5 
seconds. Because after five seconds we are most probably getting upgrades and 
not a "no upgrades" response.

Another solution that *could* work is to have the server use the HTTP status 
code to indicate a "no upgrades" response (along with the text). If the client 
can read the status code as soon as the response is coming in, then it will now 
what it is downloading.

Original comment by christof...@stoffiplayer.com on 22 Apr 2012 at 12:38

• Changed state: Accepted
• Added labels: Milestone-Qin

[GoogleCodeExporter]

My proposed solution is even simpler: let the user close Stoffi without any 
dialog. Remove the dialog completely.

Look at Windows Update: If you are busy downloading an update in the background 
and decide to shutdown, it simply redownloads the update again when you log 
back in.

1. For people with bandwidth restrictions: They can choose the option, Let me 
check for upgrades. This is tied to a feature request I will be posting: Allow 
the user to have multiple upgrade policies dependent on the network they are 
connected to.

a. When connected to 3G network x, or using z network adapter: Let me check for 
upgrades.
b. When I am at the office on network y, or using w network adapter: Upgrade 
automatically.

2. For people without bandwidth restrictions: Download the update again.

One more dialog handled in a very different way :)

Original comment by wic...@gmail.com on 22 Apr 2012 at 1:42

[GoogleCodeExporter]

Wasn't it you who requested this dialog to begin with? Anyway, it makes sense 
for users just to set the policy themselves. It was a feature request to add 
that dialog, but maybe I should remove it and just tell users to use the 
existing settings instead.

Just a heads up on that feature request: it will not be in Zhou, too 
complicated. But a great idea, though.

Original comment by christof...@stoffiplayer.com on 22 Apr 2012 at 6:32

[GoogleCodeExporter]

Yes, you're right, a year ago, Bug 241, wow, thanks for the flashback. 

We all evolve :)

It was a good idea at the time, but this is a better idea. More elegant, more 
functional, more silent. One less dialog.

Original comment by wic...@gmail.com on 22 Apr 2012 at 6:44

[GoogleCodeExporter]

This issue was closed by revision r1045.

Original comment by christof...@stoffiplayer.com on 22 Apr 2012 at 8:55

• Changed state: Fixed