shadow578 / Marlin-H32

Marlin for HC32F460 based printers (now in upstream)
http://marlinfw.org
GNU General Public License v3.0
13 stars 7 forks source link

Shadow578 h32 #17

Closed classicrocker883 closed 1 year ago

classicrocker883 commented 1 year ago

I hope I am doing this correctly.

I edited files to so the #include " " paths work in the HC32 library files, maybe not all the files but it at least compiles correctly.

if for any reason this doesn't work the same repo and changes made can be found here

shadow578 commented 1 year ago

it seems like you did a lot more than just change some include paths. Tho i believe this was not intentional and is caused because you did not fork the repo.

If you wish to contribute, please create a fork of this (shadow578/Marlin-H32) repo. Also, please do not merge upstream changes from the main marlin repo, as it'd get very hard to distinguish your changes from upstream ones.

Lastly, please describe in more detail what changes you did. As far as i understand you changed some of the include directives to make the project compile. However, the project should be able to compile as-is. if not, please open a issue for this as it'd hint to a bigger issue

classicrocker883 commented 1 year ago

I like to at least pretend to know what I'm doing 😅. no worries tho. I wish github would allow me to fork a fork if I wanted to. like since I already have a Marlinfirmware/Marlin fork, it doesn't allow me to create your fork because your's has the same Marlin upstream. there must be a good reason for that, otherwise it's kinda dumb not to.

so basically what I did was create a separate branch in my Marlin fork repo so I was able to do the pull request, otherwise I have a separate stand alone repo that I mainly do the editing with. I just don't get how it compiles fine even though the include directory paths give errors, yet compiles u know?