shadow578 / Marlin-H32

Marlin for HC32F460 based printers (now in upstream)
http://marlinfw.org
GNU General Public License v3.0
13 stars 7 forks source link

[BUG] Some terms should be updated #45

Closed classicrocker883 closed 9 months ago

classicrocker883 commented 9 months ago

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

for instance:

in src/HAL/HC32F46x/inc/Conditionals_post.h

#if USE_FALLBACK_EEPROM
#define SDCARD_EEPROM_EMULATION
-#elif EITHER(I2C_EEPROM, SPI_EEPROM)
+#elif ANY(I2C_EEPROM, SPI_EEPROM)
#define USE_SHARED_EEPROM 1
#endif

// Allow SDSUPPORT to be disabled
-#if DISABLED(SDSUPPORT)
-#undef SDIO_SUPPORT
+#if !HAS_MEDIA
+#undef ONBOARD_SDIO
#endif

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

current

Printer model

No response

Electronics

No response

Add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

Additional information & file uploads

No response

classicrocker883 commented 9 months ago

this may be a bit off topic, but I thought I would share this if you dont know about it already

https://www.xhsc.com.cn/Productlist/info.aspx?itemid=1853&parent

if you convert it to english, under the development tools tab you will see something like this.
updated files for this chip HC32F460_DDL_Rev3.1.0.zip

shadow578 commented 9 months ago

hi, thanks for opening the issue. i've merged the upstream changes yesterday and forgot to apply some changes to the HAL before merging, so rn the aquila branch is broken. i'm working on a fix in https://github.com/shadow578/Marlin-H32/pull/44 already.


this may be a bit off topic, but I thought I would share this if you dont know about it already

https://www.xhsc.com.cn/Productlist/info.aspx?itemid=1853&parent

if you convert it to english, under the development tools tab you will see something like this. updated files for this chip HC32F460_DDL_Rev3.1.0.zip

i'm aware of that page, but i did not yet notice that the DDL has been updated. i'll look into the changes and update the ddl framework sometime then