shadowcz007 / comfyui-mixlab-nodes

Workflow-to-APP、ScreenShare&FloatingVideo、GPT & 3D、SpeechRecognition&TTS
https://mixlabnodes.com
MIT License
1.32k stars 83 forks source link

最新版本mixlab会导致comfyui所有节点断线(复现实测) #324

Closed abc77654 closed 2 months ago

abc77654 commented 2 months ago

今天无意升级了mixlab节点,结果再开启comfui的所有工作流,包括默认工作流都断线了, image hui'zhe'ya会这样,线全部断开,不管重新更新comfyui还是更新所有节点,重启电脑都一样,于是我重新开了一个新的comfyui官方最新版本解压,实测发现只要安装mixlab节点,就断线,但是以前mixlab节点是一直能用的,也没问题,所以我是觉得极大概率是最新mixlab的更新有bug,

abc77654 commented 2 months ago

只要停用mixlab或者卸载都可以恢复正常连线状态

shadowcz007 commented 2 months ago

试下,应该是适配好了。Compatible with ComfyUI_frontend v1.2.48.

shiertier commented 2 months ago

依旧断线

于10:56更新至最新版本comfyui和mixlab

启动参数: python3 main.py --listen python3 main.py --listen --front-end-version Comfy-Org/ComfyUI_frontend@1.2.48

均断线,停用mixlab可以恢复正常连线状态

image

shiertier commented 2 months ago

git checkout 02dbc72 更改mixlab为更早期版本也可以恢复正常连线状态

zyc6581750 commented 2 months ago

试下,应该是适配好了。Compatible with ComfyUI_frontend v1.2.48.

没有好,退到9.17的版本就正常了。

shadowcz007 commented 2 months ago

git checkout 02dbc72 更改mixlab为更早期版本也可以恢复正常连线状态

02dbc72 后,也没干啥大的改动呀 😓

abc77654 commented 2 months ago

我最后一次修复好,感觉就更改了python版本降级为3.10, 95f35adf1fa48506ae98651500372f5

muzimusi commented 2 months ago

git checkout 02dbc72 更改mixlab为更早期版本也可以恢复正常连线状态

02dbc72 后,也没干啥大的改动呀 😓

看着是这个commit b2479e引入的

shiertier commented 2 months ago

@shadowcz007 建议先将此处回退

//reset in case of error
if (!this.viewport) {
  ctx.restore()
  // ctx.setTransform(1, 0, 0, 1, 0, 0)
  ctx.setTransform(window.devicePixelRatio, 0, 0, window.devicePixelRatio, 0, 0)
}
this.visible_links.length = 0
christian-byrne commented 2 months ago

@shadowcz007 Sorry, I should have mentioned:

You may add a conditional check to see what frontend version the user is running. The version number is exposed on global scope: https://github.com/Comfy-Org/ComfyUI_frontend/blob/efa2fa269dbf4e2fd9b30b2c90cd09b98c8f3c91/index.html#L18

shadowcz007 commented 2 months ago

Temporarily added a check for window.devicePixelRatio to resolve compatibility across different versions.

d9edbd535eb6f5705583833e3133b11cc95b27c4

yanxbo2022 commented 2 months ago

更新comfyui-mixlab-nodes节点后可以解决断线问题