search

shadowfacts / Forgelin

Fork of Emberwalker's Forgelin with some sprinkles on top.
Other
94 stars 30 forks source link

Forgelin lacks an @Mod so it can't be sorted as a dependancy #5

Closed yrsegal closed 7 years ago

yrsegal commented 7 years ago

This would allow much more informative error logs when trying to use the kotlin adapter, as right now it just has a generic ClassDefNotFound if Forgelin is missing, rather than having the standard dependency screen people are used to.

shadowfacts commented 7 years ago

I would change it, but there's some mod that shades Forgelin, and adding an @Mod class would then break when the mod that's shading it and Forgelin itself were in the same instance.

yrsegal commented 7 years ago

Maybe that'd be a good way to convince that person to not shade it. :P

shadowfacts commented 7 years ago

The only problem is, I don't remember who's doing the shading :P

yrsegal commented 7 years ago

I still say that someone else doing something wrong isn't a good reason to prevent yourself from doing something right

Eladkay commented 7 years ago

It's me and I'm not doing it

shadowfacts commented 7 years ago

Alright, I'll try to change it soon.

shadowfacts commented 7 years ago

1.3.0 now has an @Mod annotated object, and you should be able to use required-after:forgelin; in @Mod.dependencies. It's on my Maven repo and is currently pending approval on CurseForge.