shadowfacts / shadowfacts.github.io

My website
https://shadowfacts.net
6 stars 4 forks source link

Typo #16

Open Mrkuff opened 6 years ago

Mrkuff commented 6 years ago

It's me again! Found this on 1.12 tuto Basic block:

public class ModBlocks {

public static BlockOre oreCopper = new BlockOre("ore_copper").setCreativeTab(CreativeTabs.MATERIALS);

public static void register(IForgeRegistry<Block> registry) {
    register.registerAll(
            oreCopper
    );
}

register.registerAll = registry.registerAll(

Mrkuff commented 6 years ago

Another typos in RegistrationHandler section

Method registerModels need to be used instead of registerItems to register Models

Basic items Page: @Mod.EventBusSubscriber public static class RegistrationHandler {

// ...

@SubscribeEvent
public static void registerItems(ModelRegistryEvent event) {     -----registerModels
    ModItems.registerModels();
}

}

in ModItems and ModBlocks the registering models method are .registerModels() Basic Blocks page: @Mod.EventBusSubscriber public static class RegistrationHandler {

// ...

@SubscribeEvent
public static void registerItems(RegistryEvent.Register<Item> event) {
    ModItems.register(event.getRegistry());
    ModBlocks.registerItemBlocks(event.getRegistry());
}

@SubscribeEvent
public static void registerModels(ModelRegistryEvent event) {
    ModItems.registerItemModels();  ----- ModItems.registerModels();
    ModBlocks.registerItemModels();  ----- ModBlocks.registerModels();
}

}

Mrkuff commented 6 years ago

One more : cornSeed in ModItems in Crops page :

// ... public static ItemCornSeed cornSeed = new ItemCornSeed();

public static void register(IForgeRegistry registry) { registry.registerAll( // ... corn <----- cornSeed ); }

public static void registerModels() { // ... corn.registerItemModel(); <---- cornSeed.registerItemModel(); } // ...

rwilliaise commented 6 years ago

These all really bugged me.