search

shadowmage45 / KerbalFoundries2

KerbalFoundries - Continued
19 stars 8 forks source link

ALG Medium doesn't retract. #23

Closed Taris9047 closed 7 years ago

Taris9047 commented 7 years ago

In fact, it retracts but the animation doesn't work. Its steering animation does not work either.

Just downloaded the 2.0.2.8 version from release.

Addendum: ALG small gears work fine. Even retracts with a single type of 'g' key. Prolly connected to the hit 'g' key twice to retract issue?

shadowmage45 commented 7 years ago

Steering only works when the wheel strut angle is set to < 1 degree. Are your struts angled or straight? (this is to only enable steering for 'front' wheels)

Should not be any difference in functionality between the small and medium (or large) gears; they all use the same code and config setup (mostly, aside from transform names). Will attempt to do some testing on this today to see if I can confirm the animation problem.

Taris9047 commented 7 years ago

I did not touch any angle setting since it was installed as a front wheel of an aircraft. It should be centered by default, right?

But then again it steers. Yet the steering animation does not play. Same as retracting and lowering the gear. It retracts (aircraft nose touches the floor if I try to retract the gear) but the animation does not work.

shadowmage45 commented 7 years ago

I cannot confirm the 'does not retract' issue. When I add one of the ALG in the editor (any one) it seems to work fine; I can press the 'toggle gear' action buttion all day long, and it plays the retract/deploy animation just fine.

screenshot4

screenshot0

screenshot1

Is there a specific set of actions / state / etc needed to trigger this problem?

Taris9047 commented 7 years ago

screenshot32 On the ground, right after loaded

screenshot34 when 'g' key pressed. rear wheels bounce off like crazy, yet the nose wheel doesn't retract but descends into the floor.

screenshot36 End result. the nose wheel still clips through the floor.

ps. the animation works fine in the SPH.

Taris9047 commented 7 years ago

000_AT_Utils/ 000_Toolbar/ ActiveTextureManagement/ AirPark/ AirplanePlus/ AoATech/ ASET/ AviationCockpits/ B9_Aerospace/ B9AnimationModules/ B9PartSwitch/ BahaSP/ BDArmory/ BDMk22/ Blue_Hawk_Industries/ BurnTogether/ CAL/ ConfigurableContainers/ ContractConfigurator/ DestructionEffects/ Diazo/ EjectionSeatsToAll.cfg Firespitter/ FShangarExtender/ HullBreach/ ImprovedChaseCamera/ JSI/ KerbalEngineer/ KerbalFlightIndicators/ KerbalFoundries/ KerbalJointReinforcement/ KerbalKonstructs/ KerbinSide/ KSPWheel/ list LShipPartsModern/ MechJeb2/ MechJebAndEngineerForAll.cfg MM_README.md ModuleManager.2.8.1.dll ModuleManager.ConfigCache ModuleManager.ConfigSHA ModuleManager.Physics ModuleManager.TechTree ModuleManagerLicense.md MouseAimFlight/ MTW/ North Kerbin Weaponry/ P.E.W/ PhysicsRangeExtender/ Pilot Assistant/ ProceduralDynamics/ ProceduralParts/ QuizTechAeroContinued/ SCANsat/ scatterer/ SM_Armory/ SM_Industries/ SM_Industries.cfg SM_Marine/ SmokeScreen/ Squad/ TakeCommand/ TarisParts/ TarisParts.zip TextureReplacerReplaced/ toolbar-settings.dat* TweakScale/ VanguardTechnologies/ VesselMover/ VesselView/ WaypointManager/

File list in my mod folder. TarisParts is my own edit for somewhat powerful engines, based on stock parts. Didn't touch any .dll files or anything like that.

I'm running Windows 64bit version on Windows 10.

Taris9047 commented 7 years ago

A-4A Attack Hawk.craft.txt Craft file.

Taris9047 commented 7 years ago

Tested with a simple craft. (crafted at SPH)

screenshot39 At start.

screenshot40 'g' key pressed.

screenshot41 One wheel remains stretched...

Update: Reverted flight to launch. All wheels retracted correctly.

shadowmage45 commented 7 years ago

Thanks for the craft file and examples. When testing with the example craft from above (stock pod + 4 wheels), I can confirm there is an issue if the craft is launched with the wheels in the deployed state.

Doesn't appear to be specific to the medium-alg though, but effects any/all deployable parts using the KSPWheels modules for deployment when launched in the deployed state (all ALG, stock patched parts, SSTU/etc).

Looking into this now, would seem likely that it is caused by the action-group updating code triggering the action group on as-yet uninitialized parts. Will update with more info as I figure it out.

Taris9047 commented 7 years ago

Yeah, it doesn't seem to be ALG-Medium problem. Just tested 4 ALG-Large and 4 ALG-small on the same simple craft, one ALG-small didn't retract.

screenshot43

Thanks for following up.

shadowmage45 commented 7 years ago

Seems to be working much better now, no log-spam, and all the wheels deploy/retract like they should.

As this is a fairly critical bug that prevents proper use of the ALG (and other deployable) parts, I'll be putting together an updated release shortly (tonight for KSPWheel, likely tomorrow for KF and others).

For the time being, you could try using the updated/fixed .dll from: ( https://github.com/shadowmage45/KSPWheel/raw/dev/GameData/KSPWheel/Plugin/KSPWheel.dll ) ( click to download, replace the existing one in GameData/KSPWheels/Plugin/ )

Taris9047 commented 7 years ago

Works like a charm! Made me play https://www.youtube.com/watch?v=KngRgfP2YkQ&t=30s

Thanks!!