search

shadowmage45 / SSTULabs

Dev repository for testing/unfinished KSP parts/plugins/etc.
Other
62 stars 41 forks source link

VAB Undo issues #601

Open vossiewulf opened 6 years ago

vossiewulf commented 6 years ago

The main fuel tank (sorry KSP not running so don't have part ID) (at least) has issues when one performs an undo in the VAB. Thought it had something to do with recoloring, but no, this part can get in a bad state whenever involved in an undo.

Symptom is it's still there but not all there. Can't surface attach anything and can't get a right click context menu are the most obvious examples. Something is clearly getting in a bad state during the undo.

Contract Configurator doesn't like GPP but still works. Contares has some broken parts. Procedural Parts and JSI aren't playing well together, this causes me to crash regularly but the JSI guy won't even look at it if I'm not on 1.31. Eve complains about clouds in a bunch of locations. And I just noticed this, Final Frontier isn't liking GPP either. KSP.log

shadowmage45 commented 6 years ago

Thanks for the report. Will do some investigation on this tonight and see if I can get it cleaned up for the next release.

Would not at all surprise me if there are some issues with undo and part copying; the internal methods KSP uses for doing those functions are about as club-like as one can get with code.

shadowmage45 commented 6 years ago

Can confirm the issue on pretty much any use of the undo function.

A workaround (for now) is to drag a random part out of the editor, and attach it to the craft. The rest of the craft will become responsive and you can delete/remove the extra part (just don't use undo to do so).

Have one idea on what might be going on, the same problem that used to cause improper surface-attach on parts when they were first pulled from the editor list. Will investigate what can be done to hook into the undo action/event and trigger the collider updates.

vossiewulf commented 6 years ago

Thanks for the workaround :)