search

shadowmage45 / SSTULabs

Dev repository for testing/unfinished KSP parts/plugins/etc.
Other
62 stars 41 forks source link

No metallic effect on certain parts #607

Closed Jimbodiah closed 6 years ago

Jimbodiah commented 6 years ago

The Apollo SM does not have the metallic effect, the slider does nothing. Specular seems to work fine.

shadowmage45 commented 6 years ago

Aargghh.. I likely forgot a patch in there somewhere. Should be simple enough to get it working. All that the 'PBR-Recoloring' patches to do is change the shader... (assuming that I got all the textures exported properly).

Jimbodiah commented 6 years ago

Same with the panelled version of the Lander tank, for the outside panels the specular works but not the metallic. The tanks themselves are fine, it's just the outside panneling.

Awesome work, Mage. This is so amazing!!!!

shadowmage45 commented 6 years ago

Heh... even if I missed 2-3 parts/models, out of 500 models.... that's still >99.9% on the first pass.

Shouldn't be too hard to get them cleaned up/finished up for the next release.

Jimbodiah commented 6 years ago

Haha, I'm not counting, just letting you know what I find. I'm amazed you got all this out to begin with, this is gyuhge (seriously)!!! You raised the bar for KSP by 10ft, not just 1.

shadowmage45 commented 6 years ago

Both the SC-B-SM and MFT-LV paneling/caps should all now be using the PBR shaders when the PBR expansion is installed.

Please let me know if you run into any other parts that look like they were mis-converted / places where things are not recoloring properly.

Jimbodiah commented 6 years ago

Will do!

PS: Do you mean on the next release or on the current one (ninja re-upload?).

shadowmage45 commented 6 years ago

Ahh, sorry, I refer to them being fixed in the dev branch :)

One of these days I'll have to walk you through setting up git so you can get easy access to the dev branch. Its publicly available through the GitHub web portal, but kind of a pain to download what is needed.

Jimbodiah commented 6 years ago

No worries... no rush...

I made some PRs to update all the ModIntegrations to point to the new LV tank. So more food for a release next week maybe.

Jimbodiah commented 6 years ago

PPC and PDC as well.

shadowmage45 commented 6 years ago

PDC/PPC fixed; had a typo in the naming of 'Decoupler-A' texture set (Decouler-A... just doesn't work)

shadowmage45 commented 6 years ago

Need to add - SC-ENG-MOUNT-FLAT and the fuel tank inset-domed end-cap (tank-none?)

Jimbodiah commented 6 years ago

I checked most parts now I think, haven't seen this issue with anything else.