search

shadowmage45 / SSTULabs

Dev repository for testing/unfinished KSP parts/plugins/etc.
Other
62 stars 41 forks source link

EPL: Add resources to tanks #656

Closed Jimbodiah closed 6 years ago

shadowmage45 commented 6 years ago

Hmm.. it doesn't work with a standard :FOR[SSTU] block?

Jimbodiah commented 6 years ago

No idea. What's the difference?

shadowmage45 commented 6 years ago

One runs with the rest of the SSTU patches (:FOR[SSTU]), the other runs -after- all of the SSTU patches (AFTER[SSTU]), and should only be used when the things it is patching depends on things that were patched in the FOR[SSTU] block.

Basically, with patches that ship with a mod, you should use FOR whenever possible. Save using 'AFTER' for when you explicitly need to run after some other patch.

Jimbodiah commented 6 years ago

I'll try it out, brb.

Jimbodiah commented 6 years ago

It works!! ["Ofcourse it does" Mage thinks, rolling his eyes]

I'll change it and have a look at the other resource patches I added.

Jimbodiah commented 6 years ago

I don't see any that use AFTER... but a lot don't have FOR[SSTU] either. Would it be better to add FOR[SSTU] to all of those? They work on my end as-is, but I can change them to be safe if you like.

shadowmage45 commented 6 years ago

Generally yes - any patches that are shipped with SSTU should use the :FOR[SSTU] convention.

There might be specific exceptions to this, but I can't think of any with the current patch setup.

Jimbodiah commented 6 years ago

I'll do those along with the docking port cfgs then

Jimbodiah commented 6 years ago

Get ready for 50 pull requests though

shadowmage45 commented 6 years ago

Heh, really need to get you using Git proper -- where you can create new branch, and do all of the work on separate parts all in one PR/commit.

For now though -- please just try to target them all at the SSTU-dev branch. (when they target master, it is a few extra steps I have to do on each PR, and with many PRs, the time starts to add up -- much simpler/faster to just target the right branch from the beginning).

Jimbodiah commented 6 years ago

euhm.... let me see if I can find it (already did 3-4 PRs)

How do I do a branch? cq does that work only the web client or do I need the github app?