search

shadowmage45 / SSTULabs

Dev repository for testing/unfinished KSP parts/plugins/etc.
Other
62 stars 41 forks source link

Let's see if this works? #670

Closed Jimbodiah closed 6 years ago

Jimbodiah commented 6 years ago

Changed all the ModIntegrations to remove AFTER and change to FOR, or add FOR if it was not there to begin with.

Jimbodiah commented 6 years ago

HAH. That sure looks cool. Now to hope it works!

I deleted my old fork and created a new one from you dev fork, then made the changes and did the PR.

shadowmage45 commented 6 years ago

Hehe, with real use of Git -- you could do all of these changes locally, using your favorite text-editor, and then push a single commit that contained all the changes (or even a single push with multiple smaller commits).

Jimbodiah commented 6 years ago

Let's not push it :) If I can get this to work, it might already be a whole lot faster? :)

shadowmage45 commented 6 years ago

Oh, certainly. Much faster to merge a single PR than 50+ :)

Small steps...

Jimbodiah commented 6 years ago

ROFL... baby steps :)

shadowmage45 commented 6 years ago

Indeed, gotta start somewhere :)

The last step on these before I could merge the PR -- have you done any testing to make sure it didn't break anything? I can't really see those changes doing anything bad, but I've been surprised in the past.

If all is well during testing, I'll see about merging this (and your other PR's) for a possible update this weekend / next weekend (depending on the rest of my schedule).