search

shadowmage45 / SSTULabs

Dev repository for testing/unfinished KSP parts/plugins/etc.
Other
62 stars 41 forks source link

Hope you're sitting down... #711

Closed Jimbodiah closed 6 years ago

Jimbodiah commented 6 years ago

Here is the first pass for all the mod integrations. No doubt there will be some name changes to ship/station core, but I can change the files again at that point.

I also moved all the USI-LS files into the USI folder, ocd gotz to have order. Also consolidated all the seperate files into ship/station files.

Next to all the changes I've also added new mod integrations that I had made PRs for.

Let me know.

shadowmage45 commented 6 years ago

Seems to all look good aside from some potential changes to the LS patches due to the changes to how CONTAINERS are defined and how the modules for those parts are defined.

This is pretty much the best way to do PRs -- put all related changes into a single Pull Request. Using multiple commits like you've done is just fine, and for most purposes easier than merging in lots of separate PR's. So... good work :)

I did make a couple of small updates/fixes/changes to what you had submitted, but overall it looked very good.

Merging this in now -- we'll address the rest of the changes to SC part naming and SC/ST life-support once those parts are finished up a bit more.