shadowmage45 / SSTULabs

Dev repository for testing/unfinished KSP parts/plugins/etc.
Other
62 stars 41 forks source link

SSTU-TANK-MUS RCS is in the wrong position with respect to the mount #725

Closed blowfishpro closed 5 years ago

blowfishpro commented 6 years ago

It definitely used to be on the equipment shelf below for the skeletal mounts. It seems to be positioned at the top of the mount for all mounts now (true for both the split tank and common bulkhead variants).

screenshot1

blowfishpro commented 6 years ago

Hmm, the RCS also appears to not work, i.e. no module gets added to the part

shadowmage45 commented 6 years ago

RCS Function -- Interesting; the module should -already- be on the part, as part of the part config. Could be that I missed that, or that I'm not updating the modules' transform and/or effects properly.

RCS Positioning -- yep, bit of a known issue. I have to go into each of the model definitions for the mounts/noses and add the model-relative RCS position, movement range, and movement angle. Currently if the model def doesn't have a position spec, the code just places it at the 'origin' of the model, which is mostly incorrect, but a good enough 'default' for when values aren't specified. Probably good to have this as an official issue though, as it is one of the more noticeable problems with the parts.

shadowmage45 commented 5 years ago

List of models that need verified / fixed:

shadowmage45 commented 5 years ago

Have added RCS position specifications to the above listed engine mounts (where needed), to at least restore the positioning from previous versions.

Have also change the default parent slot for lower RCS to be the MOUNT slot; though the part still defaults to 'RCS-None' for port model selection.