search

shadowmage45 / SSTULabs

Dev repository for testing/unfinished KSP parts/plugins/etc.
Other
62 stars 41 forks source link

SRB Thrust Curves not working #745

Closed shadowmage45 closed 5 years ago

shadowmage45 commented 5 years ago

Reported on forums; no other information given.

shadowmage45 commented 5 years ago

Can confirm. Strangely, from the code perspective it should be working. The curves are valid in the editor. They are saved and restored correctly across revert/reload/launch. Code obviously is applying them to an engine module.

Potential for part-engine-module config needs to be enabled for thrust-curves? 'useThrustCuves=true' or somesuch?

blowfishpro commented 5 years ago

I believe the modules do need a flag set. I think it’s some artifact of how FloatCurve is implemented and it being null by default (I can definitely see better ways to do this but usually best, for one’s own sanity, not to ask why Squad did things the way they are)

shadowmage45 commented 5 years ago

Indeed -- it did turn out to be the module itself needing the flag set to use thrust curves.

Have toggled it on in the part configs, and verified that it works with a custom thrust curve. Need to double check that the 'default' configuration still works though...