search

shadowmage45 / SSTULabs

Dev repository for testing/unfinished KSP parts/plugins/etc.
Other
62 stars 41 forks source link

Interstage petal adapter petals re-appear after switch back from KSC #759

Closed Joker58th closed 5 years ago

Joker58th commented 5 years ago

Clean KSP 1.5.1 install SSTU 0.9.44.156 GameData folder shown in imgur album

Steps to reproduce:

  1. Add probe core and interstage petal adapter
  2. Configure petal adapter as shown in screen shot
  3. Launch
  4. Stage the petal adapter (petals detach and fall away)
  5. Return to space center without recovering
  6. Go back to vessel by using "Fly" or tracking station

The petals return with no way to removing them again.

Desired solution: The petals need to stay gone once detached.

output_log.txt

https://imgur.com/a/3IHd5Zj

shadowmage45 commented 5 years ago

You are correct -- if you jettison the panels, they should stay gone if/when that craft is reloaded. If it is not doing so, there is definitely a bug at play.

Will investigate, and should be able to have fixed up for the next release.

shadowmage45 commented 5 years ago

Interestingly, this appears to be caused by interactions when the 'deploy rotation' is set specifically to zero, where a rotation of zero in the code is often used to denote 'retracted'.

May need to implement more robust state handling, as the current functionality of the part far exceeds what was in the original design specifications, much of which apparently was not properly integrated.