search

shadowmint / llama-cpp-rs

A rusty interface to llama.cpp for rust
MIT License
7 stars 1 forks source link

About crate name #1

Closed hlhr202 closed 1 year ago

hlhr202 commented 1 year ago

if i attempt to port your binding to nodejs but still keep original llama-rs crate in pure rust. how should i solve package naming conflict.

would it be better if you rename this to llama-binding or something else to clarify its a different libs compared to llama-rs?

shadowmint commented 1 year ago

yeah, I was stumbling into this myself today trying to use the actual llama-rs and this crate at the same time.

I may rename these crates llama-cpp-sys and llama-cpp-rs because they're really bindings of llama.cpp, not really llama itself.

I just picked it because llama.cpp generates libllama and the standard naming for libfoo is foo-sys and foo-rs... but it's a bit annoying.

I'll try to get some time to do a rename tomorrow.

shadowmint commented 1 year ago

https://github.com/shadowmint/llama-cpp-rs/commit/f232d7769a809f89a77c64e95a60f690eeb2c96c renames the crate and the underlying -sys crate resolving this unambiguously now.