search

shadowmoose / pyderman

Install Selenium-compatible Chrome/Firefox/Opera/PhantomJS/Edge webdrivers automatically.
MIT License
29 stars 11 forks source link

Follow mypy strictly #15

Closed eggplants closed 2 years ago

eggplants commented 2 years ago

When I tried to use this project as a library, I noticed that no type hints were provided. So I added them.

# master
$ mypy --strict pyderman
...
Found 60 errors in 9 files (checked 11 source files)

I fixed all errors in mypy-strict mode.

shadowmoose commented 2 years ago

Looks good, although I don't love giving up older Python compatibility. Thanks for the contribution.