shadowmoose / pyderman

Install Selenium-compatible Chrome/Firefox/Opera/PhantomJS/Edge webdrivers automatically.
MIT License
29 stars 11 forks source link

pyderman.install() returns error when specifying full version of chromedriver. #19

Closed bandophahita closed 2 years ago

bandophahita commented 2 years ago

pyderman.install() returns error when specifying full version of chromedriver.

I'm looking at the latest commit (not officially released yet).
https://github.com/shadowmoose/pyderman/commit/d377c81e5684fc637388254f0f78e52748b0df0c

pyderman.install(browser=pyderman.chrome version="101.0.4951.41")

Results in: Exception: Unable to locate ChromeDriver version: 101.0.4951.41!

It appears to be related to the changes in https://github.com/shadowmoose/pyderman/pull/13/files

The code assumes that making a request to the following URL will return a version https://chromedriver.storage.googleapis.com/LATEST_RELEASE_101.0.4951.41

Looking through the xml on https://chromedriver.storage.googleapis.com/ there does not appear to be the option for that version. In fact I'm not seeing any options for LATEST_RELEASE_X.X.X.X. The options appear to be limited to LATEST_RELEASE_X.X.X

Looking up versions seems to work with the Major and patch versions. These are valid lookups: