search

shadowmoose / pyderman

Install Selenium-compatible Chrome/Firefox/Opera/PhantomJS/Edge webdrivers automatically.
MIT License
29 stars 11 forks source link

Mac m2 support #31

Closed bandophahita closed 1 year ago

bandophahita commented 1 year ago

Added support for mac m2 & expanded test coverage

bandophahita commented 1 year ago

The Pull Request check failed on the github action for Lint whereas it does not fail on the pre-commit. I'm not sure what needs to be done as it fails on INJECTED_PYDERMAN_VERSION being an invalid version.

I'm curious if it makes sense to replace the INJECTED_PYDERMAN_VERSION with a placeholder version that is pep8 compliant but can still be swapped out when python-publish.yml is triggered. Something like 0.0.0

bandophahita commented 1 year ago

Go for it. I don’t have merge rights.