Chromedriver Download URL Change

shadowmoose / pyderman

Install Selenium-compatible Chrome/Firefox/Opera/PhantomJS/Edge webdrivers automatically.

MIT License

29 stars 11 forks source link

Chromedriver Download URL Change #35

Open TillerBurr opened 1 year ago

TillerBurr commented 1 year ago

Starting with version 115, the chromedriver is downloaded in a different location in the json endpoints. This project will install the chromedriver up to version 114 due to these new endpoints.

TillerBurr commented 1 year ago

There are a couple of things that need to be decided how to approach this. There is no /LATEST_RELEASE page that I can find. It appears to me that it will involve hitting one of the end points and then parsing the response to find the latest release. To be able to move forward with changes, there are a few questions that should be decided.

What is considered the latest release? Is it stable, beta, dev or canary? Once that is decided, it's fairly straight forward to get the last known good version.
Should the new logic be in it's own module? The current tests for Chrome assume that the /LATEST_RELEASE endpoint exists and is accurate. If the new logic is put into the same chrome.py, the testing will have to be overhauled. If it's in it's own module, it should be enough to create new tests.

MarcelWilson commented 1 year ago

the testing will have to be overhauled.

After a while is it going to make sense to keep the old logic which allows users to pull down older webdrivers?

MarcelWilson commented 1 year ago

Do we know if the changes to chromedriver will apply to the chromium variants? i.e. Edge?

TillerBurr commented 1 year ago

Do we know if the changes to chromedriver will apply to the chromium variants? i.e. Edge?

As of right now, I would think it will remain the same. The latest stable is 115 using the links in drivers.edge, but the XML tree contains up to version 118.

MarcelWilson commented 1 year ago

I haven't looked at this yet, but figured I would try to tackle it this week. But before I do, I have to ask if anyone has tried the selenium webdriver manager? Does it effectively kill the need for pyderman?

mmyoungman commented 12 months ago

We've switched from pyderman to webdriver-manager. If someone is looking to do the same, here are the changes we needed to make: https://github.com/dfe-analytical-services/explore-education-statistics/pull/4254/files