search

shadowproject / shadow

ShadowCore integration/staging tree
MIT License
95 stars 62 forks source link

Correct SDT nomenclature needs to appear for Private coin send / balance transfer #43

Closed LiteBit closed 7 years ago

LiteBit commented 7 years ago

When in Send window the currency code SDC appears in Balance box for both public and private selections. This happens for both "Make Payment" and "Balance Transfer" tabs. Screenshots below:

capture capture2

https://doc.shadowproject.io/#shadowtokens-sdt labels the "private" coins as SDT or ShadowTokens.

dasource commented 7 years ago

Interesting SDT came about to distinguish the two ... but in reality they are still SDC ... I guess there is no harm in replacing SDC on Private Balance to "Shadow" and being done with SDT in full?

What do others think? @rynomster @kewde @crz- ?

kewde commented 7 years ago

Will fix tomorrow along with deleting GUI text inputs when switching between "make payment" <-> "balance transfer".

LiteBit commented 7 years ago

I've always like "Shadow" over SDT. Interesting to know that it's really all just SDC. Our docs could be clearer with that maybe.

dasource commented 7 years ago

@LiteBit Shadow is the correct terminology per whitepaper. Lets stick to that @code, thanks.

kewde commented 7 years ago

I think for now we'll just stick with SDC. Keeping it simple, one word to define the currency. Reving the concept of Shadow/SDT is a hassle, we moved to public vs private balance for a reason.