search

shadowproject / shadow

ShadowCore integration/staging tree
MIT License
96 stars 60 forks source link

There is no install target in the qmake project #58

Closed come-maiz closed 8 years ago

come-maiz commented 8 years ago

qmake has a simple way to define the files that have to be installed when make install is called: https://doc.qt.io/qt-5/qmake-advanced-usage.html#installing-files

This project just leaves the binary in the build path. I think it should offer also the way to install it in a system wide path.

rynomster commented 8 years ago

We can add it, possibly in /usr/local/bin by default?

On Oct 14, 2016 16:52, "Leo Arias" notifications@github.com wrote:

qmake has a simple way to define the files that have to be installed when make install is called: https://doc.qt.io/qt-5/qmake-advanced-usage.html#installing-files

This project just leaves the binary in the build path. I think it should offer also the way to install it in a system wide path.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shadowproject/shadow/issues/58, or mute the thread https://github.com/notifications/unsubscribe-auth/AGl7FRVt3BSQYD9sVr-BzMYf1DiFHICQks5qz5cVgaJpZM4KXGLp .

come-maiz commented 8 years ago

I think so. I'll prepare the PR for you to review.

rynomster commented 8 years ago

Awesome thank you :)

On Oct 14, 2016 17:02, "Leo Arias" notifications@github.com wrote:

I think so. I'll prepare the PR for you to review.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shadowproject/shadow/issues/58#issuecomment-253826657, or mute the thread https://github.com/notifications/unsubscribe-auth/AGl7FdvdCX59j57vhqk2HAx70gmTNPCWks5qz5mXgaJpZM4KXGLp .