search

shadowproject / shadow

ShadowCore integration/staging tree
MIT License
95 stars 62 forks source link

Bridge clean up and improvement #60

Closed kewde closed 7 years ago

kewde commented 7 years ago

I've replaced how the bridge passes the messages to the Javascript. It's used to generate a JSON string before and pass that, but it's not an optimal situation because JSON has/is: a) banned Unicode characters which had to be filtered out b) not as efficient as passing arrays

!!! Also needs a merge from the GUI repo !!!

Also includes an improvement to the command line version which now provides option to unlock wallet for staking for unlimited amount of time.

kewde commented 7 years ago

We need to fix TravisCI

The command "cd $INDIR && wget --user="$AUTH_USER" --password="$AUTH_PASSWORD" $DEPS_URL/$DEPS [ $EXTRADEPS != "" ] && echo $DEPS_URL/$EXTRADEPS" failed and exited with 6 during .

rynomster commented 7 years ago

Yeah I'll fix it, need to remove the password authentication so that it works for pull requests.

Fixed it 👍

I'm currently using my mbp, so I can't merge the UI part. We need to move that to a public repo, and integrate with travis-ci :O we should do the transifex pull as well on travis, will make our lives much easier.

On Oct 23, 2016 17:33, "Kewde" notifications@github.com wrote:

We need to fix TravisCI The command "cd $INDIR && wget --user="$AUTH_USER" --password="$AUTH_PASSWORD" $DEPS_URL/$DEPS[ $EXTRADEPS != "" ] && echo $DEPS_URL/$EXTRADEPS" failed and exited with 6 during .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shadowproject/shadow/pull/60#issuecomment-255595161, or mute the thread https://github.com/notifications/unsubscribe-auth/AGl7FUpE6qIqXKfcd__H0ObQzQrc9N0tks5q235mgaJpZM4Kd47o .