shadowsocks / ShadowsocksX-NG

Next Generation of ShadowsocksX
GNU General Public License v3.0
32.47k stars 7.94k forks source link

Feat(QRCode): Enhance 'Scan QR Code From Screen' notifications # #1250 #1501

Closed hiddenSharp429 closed 4 weeks ago

hiddenSharp429 commented 4 weeks ago

Improve the clarity of notifications in the QR code scanning feature:

  1. Permission handling:
    • Show notification when screen recording permission is missing
    • Automatically open system settings for permission grant

feature1

  1. Enhanced scanning status notifications: When no QR code found:

    • Title: "Scanned X displays"
    • Subtitle: "No QR codes found"
    • Body: "Try adjusting the QR code position on your screen"

    When invalid QR codes found:

    • Title: "Found X QR code(s)"
    • Subtitle: "No valid Shadowsocks URLs"
    • Body: "QR codes found are not Shadowsocks configuration"

    When valid QR codes found:

    • Title: "Found X Shadowsocks URL(s)"
    • Subtitle: "Scanned X displays, found X QR codes"
    • Body: "Successfully added X server configuration(s)"

feature2

hiddenSharp429 commented 4 weeks ago

Resolve invalid QR code scanning issue #1250

hiddenSharp429 commented 4 weeks ago

@lkebin I saw a recent PR mentioned you, Could you help review this PR?

hiddenSharp429 commented 4 weeks ago

The following error was encountered during the CI build process:

Makefile.am:21: error: Libtool library used but 'LIBTOOL' is undefined

This seems to be a configuration issue with the build system and has nothing to do with my code changes. Should I resubmit the PR?

hiddenSharp429 commented 4 weeks ago

@lkebin Hi maintainers,Could you please help to re-run the workflow? I noticed the build failed due to some configuration issues, but I don't have the permissions to trigger a rebuild myself.Thank you for your time and code review!