search

shadowsocks / shadowsocks-android

A shadowsocks client for Android
Other
35.06k stars 11.58k forks source link

upgrade to SIP022 ciphers #2887

Closed dev4u closed 2 years ago

dev4u commented 2 years ago

(https://github.com/shadowsocks/shadowsocks-android/discussions/2865) Maybe really need to release a new version, so more people can test the new ciphering. The new ciphering may cause the cell phone's battery to be less durable.

Mygod commented 2 years ago

@madeye What's your thoughts on this 2022 shenanigans? I haven't been bothered to read it yet.

zonyitoo commented 2 years ago

Apart from SIP022 (AEAD-2022), there are some improvements in shadowsocks-rust:

  1. shadowsocks-crypto's ciphers have been switched to RustCrypto community, which is in more active development. But RustCrypto's implementations are slightly slower than crypto2.
  2. An experimental tun interface support. It still need performance improvement but working well in most cases.
  3. Supporting | and || in ACL rules for better performance.

AEAD-2022 is ready for test, what do you think about this new protocol? @Mygod

Mygod commented 2 years ago

I am unconvinced that a backwards-incompatible upgrade is necessary.

dev4u commented 2 years ago

2022协议能走多远？这没人能预测。向后兼容，这更无从说起。 一套协议肯定不是一蹴而就，要经过不断修改、验证、再修改……主要方向对了，那就开干吧。 shadowsocks的协议，也不是一开始就是现在这样，中间也有翻阴沟的时候，例如ota就直接被舍弃。 SS得以各位大佬的奉献，让SS得以持续向前发展。 2022协议，就是为了修复现有协议的缺陷才设计出来的。经过我个人试用后，仍存在某些缺陷。就算是这样，个人觉得还是应该让更多的人参与进来。只有扩大测试人群，得到足够的反馈，才能验证新协议是否有效。

zonyitoo commented 2 years ago

I am unconvinced that a backwards-incompatible upgrade is necessary.

Some discussions in shadowsocks-org have shown that there may be no compatible way to resolve the security flaws. Proposal in SIP022 might be the minimal modification against the SIP004 AEAD protocol.

In the UDP protocol, the main goal is to reduce cryptography overhead, so SIP002 introduces a simple session based protocol. It performs well in stress test.

It is not perfect, maybe. So I will still keep shadowsocks-rust v1.15.0 in alpha release. shadowsocks-android may make an alpha release for letting more users to join.

madeye commented 2 years ago

@Mygod no matter what I think, they decided to add this cipher... Maybe we just follow it and do some experimental releases, in case anyone wants to give it a try.

chuxi commented 2 years ago

I just released it myself with self-updated ss-rust version v1.14.3 :(

I am unconvinced that a backwards-incompatible upgrade is necessary.

agree with you. but I also updated my server side. because the old version not works anymore. Always detected and blocked on vultr.

madeye commented 2 years ago

Attaching an experimental release here: https://www.dropbox.com/s/qmqptqpu1vbhxlk/shadowsocks-rust-1.15.0-nightly.apk?dl=0

dev4u commented 2 years ago

有点难为你了，大兄弟。

dev4u commented 2 years ago

如果有小伙伴构建这个PR的，请将ss rust依赖版本更新至：https://github.com/shadowsocks/shadowsocks-rust/commit/c9f7a7b8aed8c5209d241cfe2982015dd899d423 ref https://github.com/shadowsocks/shadowsocks-rust/issues/855