search

shadowsocks / shadowsocks-nodejs

https://github.com/shadowsocks/shadowsocks
Other
1.25k stars 724 forks source link

Better cross platform dev #109

Closed ysmood closed 9 years ago

ysmood commented 10 years ago

Checkout the Windows test: https://ci.appveyor.com/project/ysmood/shadowsocks-nodejs

clowwindy commented 10 years ago

Thanks for the work! Some of the commits are helpful. However, some changes make it hard for users to use this project.

Please take into consideration that MOST of the users don't know anything about node and npm. They just want to download and run. And they wrote blogs to tell people how they thought this project should be used.

Please check these blogs and make sure they will work as before after the pull request is merged.

http://sae.chenshaoju.com/?p=14 http://xsinger.me/diy/107.html http://blog.yesmryang.net/shadowsocks-nodejs-obfsproxy-aws/ https://gist.github.com/4239233/f537ea0a9267de69a7cb1b9d3ee6ad3851e78f10

ysmood commented 10 years ago

@clowwindy What you mean by saying?

don't know anything about node and npm

The changes I made only require people to have installed node. People only have to run npm install -g shadowsocks, and everything should work.

You merge my code, and run npm publish, that's all. (I don't have the write permission to do this)

clowwindy commented 10 years ago

Bo, they don't even know how to use command line.

All they know is to open local.js file with node.exe.

ysmood commented 10 years ago

@clowwindy Then, you should use the Github release page to upload the builded code for stable version:

https://github.com/clowwindy/shadowsocks-nodejs/releases

ysmood commented 10 years ago

The source code is for the people who want to make a contribution. I could write a Cake task to help you create release zip file, and add a direct download link in the Readme. If you could give me the write permission to this project.

clowwindy commented 10 years ago

Putting a big download button in the README seems a good idea. However, I can't ask people to rewrite blog articles like this one. When people search "how to use shadowsocks-nodejs", these blogs pop out in the first place. If the project has changed, people who have followed the blogs will fail.

Anyway, thanks for the effort. What I need right now is something else rather than cleaning the code.

Since node.js v0.10, shadowsock-nodejs is almost unusable for its huge memory footprint, due to the new buffer model. So I simply dropped out shadowsocks-nodejs development and focus on other versions. On a production environment with 2K concurrent connections, Python version only takes 20MB RAM (400MB on node.js) and uses half as CPU as node.js. So I've lost interest to work on this node.js version. Until this problem is solved, there will be no new version released.

ysmood commented 10 years ago

Well, I'll take time to dig into the memory issue, see if I can help.

clowwindy commented 10 years ago

Thanks! That'll be appreciated.