search

shadowsocks / shadowsocks-rust

A Rust port of shadowsocks
https://shadowsocks.org/
MIT License
8.7k stars 1.18k forks source link

Make a new tagged release #1775

Open link2xt opened 6 days ago

link2xt commented 6 days ago

Since all the panics in #1770 are fixed, would be nice to have a new tagged release once there are no blockers. There have been no releases on crates.io for 2 months.

zonyitoo commented 6 days ago

I am still waiting for hickory-dns's new release.

link2xt commented 3 days ago

@zonyitoo Why is the new release of hickory-dns needed? CI seems to pass and there are no git dependencies in Cargo.toml, so could the release be tagged now and new release with updated hickory-dns tagged later?

zonyitoo commented 3 days ago

Newer version of hickory-dns upgrades its dependencies like h3, … to the latest. The older one depends on some crates that has been marked deprecated.

Making ServerConfig::new to return a Result is a breaking change. So there must be a new release with a new minor version. So do upgrading hickory-dns to a newer version.

What’s the urgency to make a new release right now with only one change? It would be nice if you could depends on the git repository to test if there are any other bugs haven’t found.

link2xt commented 3 days ago

It's not really urgent, but users keep reporting that attempts to add ss:// proxies crash the whole messenger app. If hickory-dns upgrade comes somewhat soon then it's fine.

zonyitoo commented 3 days ago

I will wait until December. If hickory-dns didn’t make their stable release, then I would make a new minor release.

zonyitoo commented 1 day ago

Tracking issue: https://github.com/hickory-dns/hickory-dns/issues/2206