search

shadowspore / t38c

Tile38 Client package
MIT License
83 stars 33 forks source link

Expanding the scope of the builder field function #63

Open jakoguta opened 1 year ago

jakoguta commented 1 year ago

The function Field(name string, value float64) in the builders take a value as a float64. This makes the function not support strings, boolean and JSON. However, when building the command, the float64 is converts to a string using floatString(val float64) string. Should it then just take a string as a value like so Field(name string, value string) thus allowing for support of the missing types?

anwsimon commented 1 year ago

Also interested if there is any update here ^ As of the latest Tile38 update Field can accept more than just Float64 values. https://tile38.com/commands/set#fields

vishvanath-gojek commented 1 year ago

bumping this thread once again, if t38c maintainers plan to support updated version of t38?