Missing `@babel/core` and `webpack` dependencies

[rtritto]

Summary

After I install next-pwa with yarn, I get dependency not found warnings in yarn log.

Respectively peerDeependencies:

• webpack is of babel-loader, clean-webpack-plugin, terser-webpack-plugin and workbox-webpack-plugin dependencies; it should be moved from peerDependencies to dependencies
• @babel/core is of babel-loader; it should be added in dependencies

Versions

• next: 11.1.2
• next-pwa: 5.4.0

How To Reproduce

Steps to reproduce the behavior:

1. yarn init -y
2. yarn set version berry
3. yarn add next next-pwa react react-dom
4. See yarn log

Results

Actual

yarn log:

➤ YN0000: ┌ Resolution step
➤ YN0002: │ next-pwa@npm:5.2.24 [c7941] doesn't provide @babel/core (p68390), requested by babel-loader
➤ YN0002: │ next-pwa@npm:5.2.24 [c7941] doesn't provide webpack (pfd381), requested by babel-loader
➤ YN0002: │ next-pwa@npm:5.2.24 [c7941] doesn't provide webpack (p8d32d), requested by clean-webpack-plugin
➤ YN0002: │ next-pwa@npm:5.2.24 [c7941] doesn't provide webpack (p11d71), requested by terser-webpack-plugin
➤ YN0002: │ next-pwa@npm:5.2.24 [c7941] doesn't provide webpack (pe5f74), requested by workbox-webpack-plugin
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed
➤ YN0000: Done with warnings

Expect

No warning in yarn log.

Workaround

Add in .yarnrc.yml:

packageExtensions:
  next-pwa@*:
    dependencies:
      "@babel/core": "*"
      webpack: "*"
...

[myyk]

This was super confusing for me as a new user to next and yarn. Thanks for the workaround. It would be nice to see this fixed.

[jacobjove]

This is still an issue:

➤ YN0000: ┌ Resolution step
➤ YN0002: │ next-pwa@npm:5.6.0 [09d8e] doesn't provide @babel/core (pf3fbe), requested by babel-loader
➤ YN0002: │ next-pwa@npm:5.6.0 [e2932] doesn't provide @babel/core (p6251e), requested by babel-loader

[nomaanulhasan]

I was also getting same warnings, but workaround resolved the issue at my end: screenshot

Thanks for the workaround. It would be nice to see this fixed.

Versions

• next-pwa: "^5.6.0"
• next: "13.1.2"

[Shani-Sinojiya]

please, help me in pnpm.

• next: 13.2.4
• next-pwa: 5.6.0

Module not found: Error: Can't resolve 'babel-loader' in 'D:\project'
resolve 'babel-loader' in 'D:\project'
  Parsed request is a module
  using description file: D:\project\package.json (relative path: .)
    resolve as module
      looking for modules in D:\project\node_modules
        single file module
          using description file: D:\project\package.json (relative path: ./node_modules/babel-loader)
            no extension
              D:\project\node_modules\babel-loader doesn't exist
            .js
              D:\project\node_modules\babel-loader.js doesn't exist
        D:\project\node_modules\babel-loader doesn't exist
      D:\node_modules doesn't exist or is not a directory

webpack 5.74.0 compiled with 1 error in 1193 ms
info  - Creating an optimized production build. ELIFECYCLE  Command failed with exit code 4294967295.

[danielrotaermel]

for me adding public-hoist-pattern[]=!@babel* to the .npmrc fixed it