search

shadowwalker / next-pwa

Zero config PWA plugin for Next.js, with workbox 🧰
MIT License
3.84k stars 320 forks source link

SWC Support? #309

Open alex-cory opened 2 years ago

alex-cory commented 2 years ago

Summary

Are there any plans on upgrading to SWC?

uncvrd commented 2 years ago

I imagine this would be considered once the feature is out of beta in NextJS, but also watching this as well!

alex-cory commented 2 years ago

What do you mean out of beta? We're in Next 12 now and SWC support was introduced in Next 11.

uncvrd commented 2 years ago

Because according to the docs, it's considered an Experimental feature: https://nextjs.org/docs/advanced-features/compiler#experimental-features

AlbinoGeek commented 1 year ago

Because according to the docs, it's considered an Experimental feature: https://nextjs.org/docs/advanced-features/compiler#experimental-features

Version Notes
v13.0.0 SWC Minifier enabled by default.
v12.3.0 SWC Minifier stable.
v12.2.0 SWC Plugins experimental support added.

We are still not using next-pwa in most of our apps because it doesn't support SWC and throws hundreds of yarn warnings about workbox, webpack, etc etc.

pixelass commented 1 year ago

I haven't experienced any blockers with next-pwa and SWC. The only packages that still request babel are cypress and the usual suspect: storybook.

In case you're interested in my setup: https://github.com/pixelass/pwa-template

AlbinoGeek commented 1 year ago

I haven't experienced any blockers with next-pwa and SWC. The only packages that still request babel are cypress and the usual suspect: storybook.

In case you're interested in my setup: https://github.com/pixelass/pwa-template

Cypress 😢 Have an alternative? We'd gladly switch 😀

pixelass commented 1 year ago

Cypress 😢 Have an alternative? We'd gladly switch 😀

Cypress has their own process so it shouldn't impact you in any way. Babel is not even listed in the dependencies of the example repo I posted. It will be installed by cypress and storybook if you are using either but there is zero impact on the rest of the project (AFAIK).

What I wanted to say is: "next-pwa does not have any noticable issues with SWC".

I'm not sure if this has changed since this issue was opened, but from my experience this is currently a non-issue.