shadowwalker / next-pwa

Zero config PWA plugin for Next.js, with workbox 🧰

MIT License

3.86k stars 323 forks source link

Minor update with breaking changes #394

Open JetseVerschuren opened 2 years ago

JetseVerschuren commented 2 years ago

Summary

I'm working on adding PWA support to open-tacos, and today I suddenly noticed the deployment wasn't actually building the PWA, while locally it still worked. After looking around, it turned out the new update (5.6.0) has a breaking change to the config. Since according to semver minor updates should be backwards compatible, package managers will automatically grab the latest (broken) version.

Versions

next-pwa: 5.5.4 & 5.6.0
next: 12.1.7-canary.48

How To Reproduce

Steps to reproduce the behavior:

Configure a project for next-pwa 5.5.4
Do a fresh install of all packages (which will install 5.6.0)
PWA isn't included in the build

Expected Behaviors

I expect the package to be backwards compatible between minor versions

hichemfantar commented 2 years ago

I don't know if it's possible but should probably undo the 5.6 release and republish it as 6.0